Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git commit icon #511

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Add git commit icon #511

merged 3 commits into from
Dec 6, 2024

Conversation

emilyrohrbough
Copy link
Member

Add Git Commit Icon

Screenshot 2024-12-04 at 1 26 48 PM

Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: b4a3322

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@cypress-design/icon-registry Patch
@cypress-design/react-icon Patch
@cypress-design/vue-icon Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cypress-design ✅ Ready (Inspect) Visit Preview Dec 5, 2024 9:57pm

Copy link

cypress bot commented Dec 4, 2024

cypress-design    Run #2560

Run Properties:  status check passed Passed #2560  •  git commit a43b20f12a ℹ️: Merge b4a3322bab539cbf9490622e9b83815338cc0c15 into ea13d12772b81911ab1bbd315668...
Project cypress-design
Branch Review git-commit-icon
Run status status check passed Passed #2560
Run duration 02m 46s
Commit git commit a43b20f12a ℹ️: Merge b4a3322bab539cbf9490622e9b83815338cc0c15 into ea13d12772b81911ab1bbd315668...
Committer Emily Rohrbough
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 222
View all changes introduced in this branch ↗︎
UI Coverage  11.11%
  Untested elements 171  
  Tested elements 25  
Accessibility  99.37%
  Failed rules  0 critical   1 serious   0 moderate   1 minor
  Failed elements 22  

@ryanjwilke
Copy link
Contributor

@emilyrohrbough @emilmilanov Is this icon intended to be a 1px stroke? The vast majority of our icons are 2px stroke icons, so I thought I'd check first since it looks a bit funny compared to the other icons in the preview environment.

Copy link
Contributor

@emilmilanov emilmilanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon is looking good now. Thanks Emily!

@emilyrohrbough emilyrohrbough merged commit 01f321f into main Dec 6, 2024
14 of 15 checks passed
@emilyrohrbough emilyrohrbough deleted the git-commit-icon branch December 6, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants