Add working directory parameter #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
DaveSanders
reviewed
Jul 4, 2019
bahmutov
reviewed
Jul 9, 2019
src/orb.yml
Outdated
| @@ -441,6 +471,20 @@ examples: | |||
| - cypress/run: | |||
| yarn: true | |||
|
|
|||
| custom-directory: | |||
| description: | | |||
| Runs all commands in a custom directory. | |||
There was a problem hiding this comment.
ok, everything seems good, except can you describe this example a little bit better, please? Like the use case is monorepo with front-end tests in a subfolder for example ... right?
There was a problem hiding this comment.
Yes exactly, I've improved the description a bit, do you think that's good enough now?
bahmutov
reviewed
Jul 9, 2019
src/orb.yml
Outdated
| @@ -391,6 +415,10 @@ jobs: | |||
| description: Use yarn to install NPM modules instead of npm. | |||
| type: boolean | |||
| default: false | |||
| working_directory: | |||
| description: Directory containing package.json | |||
There was a problem hiding this comment.
since this is top level parameter, could you describe its purpose a little bit more here?
bahmutov
reviewed
Jul 9, 2019
|
perfect, thank you @n6g7 |
|
Cool! Do you plan on making a release soon? :) |
|
@n6g7 I have just published v1.8.0 - give it a go |
|
Working great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
working_directoryparameter to most commands and jobs.Fixes #113 and #16.