Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 ways to turn tv off #14

Merged
merged 6 commits into from
Feb 14, 2020
Merged

3 ways to turn tv off #14

merged 6 commits into from
Feb 14, 2020

Conversation

christophsax
Copy link
Member

@christophsax christophsax commented Feb 14, 2020

  • from main session: tv::off()
  • from tv-menu
  • by closing last shiny session

fixes #9

@christophsax christophsax requested a review from krlmlr February 14, 2020 00:31
Copy link
Collaborator

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should also find a way to have both R sessions talk to each other in a reliable way, perhaps using {txtq} or stdin/stdout communication, if only to communicate the port and the temporary (!) path for storing the fst files.

tv_unregister <- function() {
push_obj(tibble::tibble(...start.up = 0)) # empty start up
# register_s3_method("base", "print", "data.table", print_html)
register_s3_method("base", "print", "tbl_df", tibble:::print.tbl)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to work around the ::: to avoid R CMD check warnings.

@christophsax christophsax merged commit 82545b1 into master Feb 14, 2020
@christophsax christophsax deleted the tv-off branch February 14, 2020 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

tv::off()
2 participants