Don't pass rose variables with state ! or !! to Cylc. #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
bugfix.rose-comments
branch
2 times, most recently
from
495d66b to
94f676a
Compare
wxtim
force-pushed
the
bugfix.rose-comments
branch
from
94f676a to
b2e1dd7
Compare
datamel
reviewed
Aug 25, 2022
wxtim
commented
Aug 25, 2022
wxtim
commented
Aug 25, 2022
| '!SINGLE="bar"\n' | ||
| '!!DOUBLE="baz"\n' | ||
| ) | ||
| result = run(split(f'cylc validate {str(tmp_path)}'), capture_output=True) |
There was a problem hiding this comment.
Can use cylc view -p here to simplify the example (no need for the scheduler or scheduling sections).
There was a problem hiding this comment.
Yes, but you have to turn jinja2 processing on with --jinja2.
There was a problem hiding this comment.
(note -p detects #!shebangs and runs the relevant processing)
replace cylc validate with cylc view --jinja2 in test
wxtim
force-pushed
the
bugfix.rose-comments
branch
from
2f42bb4 to
cc395d2
Compare
datamel
approved these changes
Aug 31, 2022
MetRonnie
pushed a commit
that referenced
this pull request
Aug 31, 2022
replace cylc validate with cylc view --jinja2 in test
wxtim
added a commit
to wxtim/cylc-rose
that referenced
this pull request
Sep 13, 2022
replace cylc validate with cylc view --jinja2 in test
wxtim
added a commit
to wxtim/cylc-rose
that referenced
this pull request
Nov 25, 2022
replace cylc validate with cylc view --jinja2 in test
wxtim
added a commit
to wxtim/cylc-rose
that referenced
this pull request
Nov 25, 2022
replace cylc validate with cylc view --jinja2 in test
wxtim
added a commit
to wxtim/cylc-rose
that referenced
this pull request
Nov 25, 2022
…mental_improvements_to_testing * 'master' of github.com:cylc/cylc-rose: Remove subprocess from tests (cylc#194) update stem - install interface (cylc#193) Update tests/unit/test_rose_stem_units.py response to review Update setup.cfg removed never used option Improve test coverage for Rose Stem reinstall changes to `rose-suite.conf` [tests] (cylc#178) Changed the rose stem functional tests to a more pytest-integration style. Bump rose dependency to `2.1.*` Bump dev version on master to next minor release (cylc#175) Fix changelog conflict with 1.1.x (cylc#186) Prepare release: 1.1.1 (cylc#183) Rose Stem Fixes (cylc#172) Don't pass rose variables with state ! or !! to Cylc. (cylc#171) Don't pass rose variables with state ! or !! to Cylc. (cylc#171) Bump cylc-flow dependency (cylc#173) functional tests only cleanup if succeeded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change with no associated Issue.
It closes an otherwise undocumented bug where variables commented in a
rose-suite.conf(with a!or!!) are passed to Cylc regardless.Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg.