-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix.do not allow multiple templating sections #133
Fix.do not allow multiple templating sections #133
Conversation
Failing tests - marked draft TL I get back from my walk. |
This reverts commit 51974c4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have manually tested cylc graph
, install
, play
One thing, the change from string to "constant" (now-reverted in 189b670) wasn't a bad idea, considering how vulnerable strings are to typos
I agree, however it was making tests fail, so I was going to do it separately and work out what the problem is. There are a lot of code style things I did a year ago that I don't like about this repo, of which this is not the biggest... |
These changes close #124
Synopsis
Cylc Rose was checking for
[empy:suite.rc]
and[jinja2:suite.rc]
both being set, but was not checking whether either was being set with[template variables]
.Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
.Other
Tagging @dpmatthews for a functional review as he raised this bug. IMO this only requires 1 full review +1 manual test.