-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky integration tests #6257
Conversation
MacOS tests failing for unrelated reasons; not tackled in this PR |
if not schd.contact_data: | ||
return True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixture was waiting for 60 secs for the workflow to shut down even if there was no contact data. If there is no contact data it must have already shut down due to an error or something (which bypasses the set_stop
method).
@@ -569,7 +569,7 @@ async def _complete( | |||
Args: | |||
schd: | |||
The scheduler to await. | |||
tokens_list: | |||
wait_tokens: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be overloaded, but I think await_tokens
would be better English.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice -One entirely subjective comment about naming which you can take or leave.
MacOS integration test failure is a flaky TUI test |
(will leave you to accept/reject Tim's suggestion and merge) |
Fixes state leakage between integration tests that was resulting in
tests/integration/reftests/test_cyclers.py::test_icp_fcp_notation
failing flakily.Salient traceback
Also it was failing in a confusing way, so I altered the integration reftest function to better handle unexpected shutdown