Ensure jobs are created if task is in waiting state #6176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
fix.submit-failed_tasks_not_showing
branch
from
b3b003c to
c6a52e6
Compare
wxtim
commented
Jun 27, 2024
| @@ -1536,10 +1536,11 @@ def _insert_task_job( | |||
| job_conf = itask.jobs[-1] | |||
|
|
|||
| # insert job into data store | |||
| job_status = 'submitted' if submit_status == 0 else 'submit-failed' | |||
| self.data_store_mgr.insert_job( | |||
There was a problem hiding this comment.
This method takes a job status, not a task status. If the task status is 'waiting' it returns None and doesn't register the job with the data store.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
wxtim
force-pushed
the
fix.submit-failed_tasks_not_showing
branch
from
a4b96c6 to
0667309
Compare
wxtim
force-pushed
the
fix.submit-failed_tasks_not_showing
branch
2 times, most recently
from
529429d to
5b406d8
Compare
oliver-sanders
requested changes
Jun 28, 2024
tests/integration/tui/screenshots/test_auto_expansion.later-time.html
Outdated
Show resolved
Hide resolved
wxtim
changed the title
|
(rebase to pick up flake8 fixes on upstream/8.3.x) |
wxtim
force-pushed
the
fix.submit-failed_tasks_not_showing
branch
from
7aef19a to
98620f1
Compare
wxtim
force-pushed
the
fix.submit-failed_tasks_not_showing
branch
from
c584830 to
a8d39eb
Compare
Update tui test KGO added a test Apply suggestions from code review Co-authored-by: Oliver Sanders <[email protected]>
wxtim
force-pushed
the
fix.submit-failed_tasks_not_showing
branch
from
a8d39eb to
c0ae6b8
Compare
wxtim
commented
Jul 4, 2024
oliver-sanders
approved these changes
Jul 4, 2024
MetRonnie
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6172
Repro:
With
global.cylc:Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.