Play should have no cylc rose options #6068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic removed was designed to handle option config being either a new Options object, or just a dict. There are no options defined as just a dict anymore.
wxtim
commented
Apr 16, 2024
| @@ -309,12 +309,8 @@ def get_option_parser(add_std_opts: bool = False) -> COP: | |||
| argdoc=[WORKFLOW_ID_ARG_DOC] | |||
| ) | |||
|
|
|||
| options = parser.get_cylc_rose_options() + PLAY_OPTIONS | |||
| for option in options: | |||
| if isinstance(option, OptionSettings): | |||
There was a problem hiding this comment.
There are no longer any options stored as Dicts rather than OptionSettings objects :. this is redundant.
8 tasks
MetRonnie
reviewed
Apr 16, 2024
|
(breaking change entry I'm afraid) |
oliver-sanders
approved these changes
Apr 17, 2024
MetRonnie
approved these changes
Apr 17, 2024
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Apr 22, 2024
* upstream/master: (25 commits) Delete public DB if private DB does not exist on scheduler start (cylc#6070) Include xtrigger function signatures in `cylc config` (cylc#6071) Add Nano syntax highlighter (cylc#6072) Play should have no cylc rose options (cylc#6068) tests/integration: address urwid deprecation warning (cylc#6063) Bump dev version Prepare release 8.2.5 add mailmap entry Tutorials: avoid validation errors due to implicit tasks Update CONTRIBUTING.md Update xtrigger_mgr.py documentation Another small tweak. Tweak previous. Tutorials: increase sleep and don't sleep in CI Fix bad doctests tutorial: make the tutorial workflow run a little slower Style tweaks. Simply workflow-state code a bit. Add unit tests for workflow-state. Add to doc string. ...
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
& Reload should not mess with Cylc Rose CLI options.
Companion to cylc/cylc-rose#312
Cylc Play was (according to the proposal doc) never intended to take Rose config CLI options (
-O,-Dand-S).For example:
Would lead to foo = 2 being stored on the scheduler as
self.options.rose_template_vars: If we then doWill lead to the installed files updating, but reload cannot update the
self.options.rose_template_varsobject created by Cylc Play, so we cannot get rid offoo=2.Without the scheduler storing these items, reload can examine all the files and get the updated value.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.