Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint packaged workflows #5873

Merged
merged 6 commits into from
Jan 26, 2024
Merged

Lint packaged workflows #5873

merged 6 commits into from
Jan 26, 2024

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Dec 12, 2023 •
edited
Loading

Closes #5095

  • Ensure that workflows packaged with Cylc (in cylc/flow/etc/tutorial) pass Cylc Lint.
  • Add the ability to create # noqa comments: This will allow us to make sure all the test workflows are also linted because it will allow us to exclude deliberately bad lines.
  • Don't object to %include if unindented.
  • Lint the packaged workflows in CI.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@wxtim wxtim self-assigned this Dec 12, 2023
@wxtim wxtim added this to the cylc-8.3.0 milestone Dec 12, 2023
@wxtim wxtim added the could be better Not exactly a bug, but not ideal. label Dec 12, 2023
@wxtim wxtim marked this pull request as draft January 22, 2024 15:36
@wxtim wxtim requested a review from oliver-sanders January 25, 2024 16:38
@wxtim wxtim marked this pull request as ready for review January 25, 2024 16:38
@oliver-sanders oliver-sanders merged commit efb3016 into cylc:master Jan 26, 2024
26 of 27 checks passed
@MetRonnie MetRonnie removed their request for review May 22, 2024 13:24
@wxtim wxtim deleted the lint_packaged_workflows branch May 22, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

@markgrahamdawson markgrahamdawson markgrahamdawson approved these changes

Assignees

@wxtim wxtim

Labels
could be better Not exactly a bug, but not ideal.
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.

Tutorial workflows should pass cylc lint
3 participants
@wxtim @markgrahamdawson @oliver-sanders