Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

play: preserve colour formatting when detaching #5461

Merged
merged 1 commit into from
Apr 14, 2023
Merged

play: preserve colour formatting when detaching #5461

merged 1 commit into from
Apr 14, 2023

Conversation

oliver-sanders
Copy link
Member

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders added this to the cylc-8.2.0 milestone Apr 12, 2023
@oliver-sanders oliver-sanders self-assigned this Apr 12, 2023
@oliver-sanders oliver-sanders requested a review from hjoliver April 12, 2023 13:59
@oliver-sanders oliver-sanders added small could be better Not exactly a bug, but not ideal. labels Apr 12, 2023
hjoliver
hjoliver approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@oliver-sanders oliver-sanders requested a review from wxtim April 14, 2023 08:50
wxtim
wxtim approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read, happy with code and test
  • Tried in practice

@wxtim wxtim merged commit c9b877d into cylc:master Apr 14, 2023
@oliver-sanders oliver-sanders deleted the 5159 branch April 14, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxtim wxtim wxtim approved these changes

@hjoliver hjoliver hjoliver approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
could be better Not exactly a bug, but not ideal. small
Projects
None yet
Milestone
cylc-8.2.0
Development

Successfully merging this pull request may close these issues.

play: colour formatting turned off
3 participants
@oliver-sanders @hjoliver @wxtim