Upload coverage to Codecov in separate job #5459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reduces how hard we hit Codecov API - Allows easy re-attempt to upload
MetRonnie
commented
Apr 11, 2023
|
The Codecov upload failed the first time it ran after all the functional tests completed. I simply re-ran the https://github.com/cylc/cylc-flow/actions/runs/4669416364/jobs/8269591985 |
|
This makes good sense and should reduce the number of uploads from 15 to 2 I think. Nice idea! Unfortunately it doesn't look like codecov is on the list of checks for this PR. It looks like it doesn't like the uploaded reports:
https://app.codecov.io/gh/cylc/cylc-flow/commit/146e923f405da354e2d3116f08e356e98b2d4e38 |
|
Dammit, I looked into this and it seemed to be a false alarm earlier 😣 |
MetRonnie
force-pushed
the
codecov
branch
3 times, most recently
from
d3041a9 to
a81a1da
Compare
No idea why this is necessary
|
Ok that should fix it. It seems the report is unusable if you don't checkout the repo in the job that uploads the report 🤷♂️ |
oliver-sanders
approved these changes
Apr 13, 2023
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Apr 14, 2023
* Convert old clock triggers to wall_clock xtriggers. * Fix test. * Update change log. * tests/f: fix job-submission/03 * bump version * deps: remove aiofiles * Aiofiles is a simple wrapper for a thread pool executor. We don't need a 3rd party library to do this for us. * Closes cylc#5306 * Update cylc/flow/__init__.py * Revert "Update cylc/flow/__init__.py" This reverts commit d40bdc1. * fix to make setup.cfg work with setuptools v67.0.0 * Use different version strings for isodatatime for python 3.7 * Update setup.cfg Co-authored-by: Ronnie Dutta <[email protected]> * id: pass tokens objects between interfaces * Change `TaskProxy.tokens` to hold the absolute ID rather than the relative ID to make the object useful in more situations. * Refactor the data_store_mgr interfaces to accept `Tokens` instances rather than raw inputs (e.g. cycle_point, task_name, etc). * This avoids doing `Tokens(str(tokens))` when passing context into the data store interfaces. * deps: loosen pyzmq dependency * The ZMTP protocol provides robust forward & backward compatibility from libzmq version 3.2.2 onwards. * Since this is the minimum version compatible with pyzmq, we can safely loosen this version coupling. * For more information see the rationale in cylc#5311 (comment) * Closes cylc#5272 * Closes cylc#5311 * Unblocks cylc/cylc-uiserver#411 * Update README.md * Quick fix for mypy * remove issue templates * Defaults can now be centrally configured in https://github.com/cylc/.github * workflow_files: move clean functionality into its own module * `cylc clean` has outgrown the workflow_files module somewhat. * workflow_files: move install functionality into its own module * remove pull request template * update CONTRIBUTING * add missing import * Bump pypa/gh-action-pypi-publish from 1.6.4 to 1.7.1 Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.6.4 to 1.7.1. - [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases) - [Commits](pypa/gh-action-pypi-publish@v1.6.4...v1.7.1) --- updated-dependencies: - dependency-name: pypa/gh-action-pypi-publish dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump pypa/gh-action-pypi-publish from 1.7.1 to 1.8.1 (cylc#5413) Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.7.1 to 1.8.1. - [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases) - [Commits](pypa/gh-action-pypi-publish@v1.7.1...v1.8.1) --- updated-dependencies: - dependency-name: pypa/gh-action-pypi-publish dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * remote: add note about sys.exit behaviour (cylc#5393) * Bump pypa/gh-action-pypi-publish from 1.8.1 to 1.8.3 Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.8.1 to 1.8.3. - [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases) - [Commits](pypa/gh-action-pypi-publish@v1.8.1...v1.8.3) --- updated-dependencies: - dependency-name: pypa/gh-action-pypi-publish dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * vr: add --yes option * tui: add vr command * add instruction to report critical traceback * CLI: short option changes * Rename `-n` for `--no-detach` to `-N`. This removes the conflict with `--workflow-name` allowing the option to be used in `cylc vip`. * Add `-r` as a short option for `--run-name`. * efficiency: pass tokens instances to get_broadcast * This saves some unnecessary tokenise/detokenise operations * Update cylc/flow/scheduler.py * Update cylc/flow/tui/data.py * Update cylc/flow/broadcast_mgr.py Co-authored-by: Tim Pillinger <[email protected]> * Apply suggestions from code review [skip ci] Co-authored-by: Oliver Sanders <[email protected]> * Bump pypa/gh-action-pypi-publish from 1.8.3 to 1.8.4 (cylc#5446) Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.8.3 to 1.8.4. - [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases) - [Commits](pypa/gh-action-pypi-publish@v1.8.3...v1.8.4) --- updated-dependencies: - dependency-name: pypa/gh-action-pypi-publish dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump pypa/gh-action-pypi-publish from 1.8.4 to 1.8.5 Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.8.4 to 1.8.5. - [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases) - [Commits](pypa/gh-action-pypi-publish@v1.8.4...v1.8.5) --- updated-dependencies: - dependency-name: pypa/gh-action-pypi-publish dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Improve documentation for retrieve job logs command * Update cylc/flow/cfgspec/globalcfg.py * fix a typo in document * actions: add build test * Stop Cylc Reinstall modifying global variables This caused the same variable to be added multiple times causing errors from clashing options. * validate-reinstall: don't print reload message * The reload message is not applicable when using `cylc vr` because it does it for you. * Closes cylc#5344 * play: preserve colour formatting when detaching * Closes cylc#5159 * Upload coverage to Codecov in separate job (cylc#5459) GH Actions: upload coverage to Codecov in separate job - Reduces how hard we hit Codecov API - Allows easy re-attempt to upload - remove unnecessary step on MacOS --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Hilary Oliver <[email protected]> Co-authored-by: Oliver Sanders <[email protected]> Co-authored-by: Melanie Hall <[email protected]> Co-authored-by: Ronnie Dutta <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dpmatthews <[email protected]> Co-authored-by: Cheng Da <[email protected]>
MetRonnie
added a commit
to MetRonnie/cylc-flow
that referenced
this pull request
Apr 14, 2023
GH Actions: upload coverage to Codecov in separate job - Reduces how hard we hit Codecov API - Allows easy re-attempt to upload - remove unnecessary step on MacOS (cherry picked from commit 1d4da4c)
This was referenced Apr 14, 2023
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Apr 17, 2023
…gex_remote_tidy_fail * upstream/8.1.x: Update cylc/flow/scripts/message.py Upload coverage to Codecov in separate job (cylc#5459) upgrade cylc message internal help with details of severity levels Update tests/functional/platforms/10-do-not-host-check-platforms.t Fix flake8-comprehensions C419 Don't use any([i for i in iterable]) use any(i for i in iterable). It's more efficient because we don't have to expand the entire thing. Improve readability of host/platform eval code (#53) small changlog error fix update comment on localhost check and add test for case localhost4.localhost42 undo mistake clarification of nomenclature Avoid running host check on platform names - this doesn't make any sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround codecov/feedback#126
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.?.?.xbranch.