Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: short option changes #5439

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Mar 29, 2023

Closes #5227

  • Rename -n for --no-detach to -N. This removes the conflict with --workflow-name allowing the option to be used in cylc vip.
  • Add -r as a short option for --run-name.

Note, -r is used as a short option for the --raw output option, however, this doesn't conflict with install/play/clean/reload/reinstall/tui so shouldn't be a conflict risk with any future compound commands.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

* Rename `-n` for `--no-detach` to `-N`. This removes the conflict with
  `--workflow-name` allowing the option to be used in `cylc vip`.
* Add `-r` as a short option for `--run-name`.
@oliver-sanders oliver-sanders added this to the cylc-8.2.0 milestone Mar 29, 2023
@oliver-sanders oliver-sanders self-assigned this Mar 29, 2023
@oliver-sanders oliver-sanders requested a review from hjoliver March 29, 2023 12:21
@oliver-sanders
Copy link
Member Author

(checked that the functional test failures were all codecov)

@oliver-sanders oliver-sanders marked this pull request as ready for review March 29, 2023 12:21
@hjoliver hjoliver merged commit 922c227 into cylc:master Mar 29, 2023
@oliver-sanders oliver-sanders deleted the cli-short-opts branch March 30, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

play: rename -n short option
2 participants