data_store: fix possible traceback with NoneType items #5394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Closes cylc#5388 * Even though `None` is a valid value for an `optional` field in Protobuf, and even though you can initiate these fields with `None` values, you cannot later set them to `None`.
MetRonnie
approved these changes
Mar 3, 2023
Comment on lines
+198
to
+200
| Note: | ||
| If the above doctest fails, then the behaviour of protobuf has changed | ||
| and this wrapper might not be necessary any more. |
wxtim
approved these changes
Mar 24, 2023
|
I've deconflicted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noneis a valid value for anoptionalfield in Protobuf, and even though you can initiate these fields withNonevalues, you cannot later set them toNone.Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.