deps: loosen pyzmq dependency #5307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-sanders
force-pushed
the
bump-dependencies
branch
from
a5ca1d8 to
5c54c49
Compare
|
The Python 3.10 failure is a codecov upload failure, but the other two look like they might be real failures. |
|
The pyzmq package on conda-forge appears to be missing Python 3.7 builds, looking in... |
|
Conda-forge has dropped 3.7 - https://conda-forge.org/docs/user/announcements.html#dropping-python-3-7 This means new releases will not be built against 3.7. |
|
Options:
|
MetRonnie
reviewed
Jan 18, 2023
oliver-sanders
force-pushed
the
bump-dependencies
branch
2 times, most recently
from
f484e24 to
5be8e69
Compare
oliver-sanders
force-pushed
the
bump-dependencies
branch
from
12a38fe to
c7a126d
Compare
|
I have changed tack on this PR and rolled #5311 into it avoiding the 3.7 issue |
* The ZMTP protocol provides robust forward & backward compatibility from libzmq version 3.2.2 onwards. * Since this is the minimum version compatible with pyzmq, we can safely loosen this version coupling. * For more information see the rationale in cylc#5311 (comment) * Closes cylc#5272 * Closes cylc#5311 * Unblocks cylc/cylc-uiserver#411
oliver-sanders
force-pushed
the
bump-dependencies
branch
from
c7a126d to
d72dad6
Compare
|
(rebased) |
wxtim
approved these changes
Feb 8, 2023
|
Want me to have a look at the mypy failures? |
|
Presumably not related to this branch? |
|
Looks like it's type annotations added to newer versions of pyzmq |
|
Actually I think I already did this earlier, must have got lost in one of the force pushes, luckily I still had the branch locally |
wxtim
approved these changes
Feb 14, 2023
MetRonnie
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tldr; We should be good to loosen off on this requirement, full rationale in the issue.