8.0.x -> master #5206
Merged
8.0.x -> master #5206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Selectors were not correctly preserved for the `task` and `workflow` properties of `Tokens` objects. * This effectively stripped cycle/task selectors from IDs passed to `cylc trigger`. * Closes cylc#5186
uid: include selectors in detokenised IDs where required * Add a new interface for retrieving the string ID including selectors from `Tokens` objects. * Use this for CLI scripts which utilise selectors (e.g. `kill`). * Fixes a bug where selectors provided on the CLI were silently stripped before being passed through GraphQL.
id: preserve selectors for "task" and "workflow" properties
Workflow: Release stage 1 - create release PR (Cylc 8+ only), run: 15 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Workflow: Release stage 2 - auto publish, run: 35 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Make shutdown more robust
…_Scan_Traceback_Bug fix an error handling bug in Cylc Scan
oliver-sanders
requested review from
wxtim
and removed request for
oliver-sanders
wxtim
approved these changes
Oct 25, 2022
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Oct 31, 2022
… of github.com:wxtim/cylc into 20221010T0945--HEAD--get_template_vars_from_running_wf * '20221010T0945--HEAD--get_template_vars_from_running_wf' of github.com:wxtim/cylc: (51 commits) make revalidate automatic if workflow has changed at source play: --upgrade and --downgrade options Fix consolidation tutorial (cylc#5199) 8.0.x -> master (cylc#5206) GH Actions Codecov upload: try using token arg (cylc#5179) Update CHANGES.md [skip ci] Add type hints. Switch to better monkeypatching approach. [skip ci] Add explanatory comments. [skip ci] Update CHANGES.md [skip ci] play: check Cylc version on restart Use a context manager in new test. Update change log. Extend new test coverage. install: scan only target workflow Apply suggestions from code review Add integration test. Scan workflow name during install. fix an error handling bug in Cylc Scan update PR template (cylc#5202) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.