-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scan workflow name during install. #5184
Conversation
f26ac09
to
65c3cd1
Compare
(Considering an integration test for this). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Perhaps add in a templated cylc stop
command to stop these additional runs.
Stop them with `cylc stop <id> ...`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, looking good. probably could do with a test as you've said.
Is there an easy way to include the state (running, paused etc) next to the listed workflows? Might help clarify what is meant by "active" in each case
2572f70
to
8456c2c
Compare
1a76aea
to
fe35caa
Compare
(Tutorial test failure unrelated) |
Two approvals, going in... |
Close #5127
Scan and report any running instances of a workflow at install time.
(Note I've used the WARNING color, but without saying "WARNING:" on grounds that already-running instances of an installed workflow might possibly indicate user error, but probably do not ... but I'm not particularly invested in this coloring!).
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
andconda-environment.yml
.CHANGES.md
entry included if this is a change that can affect users