Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tutorial workflows #5091

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Fix tutorial workflows #5091

merged 3 commits into from
Aug 25, 2022

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Aug 22, 2022

  • Map HTML file was broken due to the Jinja2 (?) double curly brackets being broken over lines
  • urllib3 requests no longer working with Met Office proxy, used requests instead, which is nicer actually

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Dependency changes only apply to setup.cfg, not conda-environment.yml (optional dependency urllib3 removed)
  • No tests needed.
  • CHANGES.md entry included if this is a change that can affect users
  • No docs needed
  • If this is a bug fix, PRs raised to both master and the relevant maintenance branch.

@MetRonnie MetRonnie added this to the 8.0.2 milestone Aug 22, 2022
@MetRonnie
Copy link
Member Author

(Test failures due to swarm build failure)

Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@oliver-sanders oliver-sanders merged commit 00e1a6c into cylc:8.0.x Aug 25, 2022
@MetRonnie MetRonnie deleted the tutorial branch August 25, 2022 16:25
@oliver-sanders oliver-sanders mentioned this pull request Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants