Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't prompt to clean no workflows. #4889

Merged
merged 2 commits into from
May 25, 2022
Merged

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented May 20, 2022

This is a small change with no associated Issue.

Master:

$ cylc clean 'sagittarius-a*'
Would clean the following workflows:
Remove these workflows (y/n): 

This branch:

$ cylc clean 'sagittarius-a*'
No workflows matching sagittarius-a*

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Does not need tests (why?).
  • Appropriate change log entry included.
  • No documentation update required.

@hjoliver hjoliver added the bug Something is wrong :( label May 20, 2022
@hjoliver hjoliver self-assigned this May 20, 2022
@hjoliver hjoliver added this to the cylc-8.0rc4 milestone May 20, 2022
@hjoliver hjoliver marked this pull request as ready for review May 24, 2022 05:38
@hjoliver
Copy link
Member Author

hjoliver commented May 24, 2022

IMO we don't really need a test to check that an unnecessary prompt doesn't get issued.

@hjoliver
Copy link
Member Author

One review will do for this.

@hjoliver hjoliver merged commit a34beba into cylc:master May 25, 2022
@hjoliver hjoliver deleted the cylc-clean-none branch May 25, 2022 00:47
@hjoliver hjoliver modified the milestones: cylc-8.0rc4, cylc-8.0.0 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants