-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Jinja2 to 3.0.* #4877
Update Jinja2 to 3.0.* #4877
Conversation
Do we want to include a complex jinja2 workflow example that we diff against a reference file, as a functional test? |
I don't think so and we wouldn't be able to capture all uses and patterns. Hopefully future upgrades won't be so complicated. The timing of this one with Cylc 8 and the need for 7/8 interoperability has made this tricky. |
# https://github.com/pallets/jinja/issues/1585 (remove when upgrading | ||
# jinja2 to >= 3.0): | ||
- markupsafe <2.1 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: remember to remove this in the conda-feedstock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but haven't manually tested.
functional tests / macos failed due to Codecov upload failure only |
These changes close #4702
Update Jinja2 from 2.11 to 3.0
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
andconda-environment.yml
.