-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cylc-rose run twice bug #4502
cylc-rose run twice bug #4502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a little confused about how this pairs with cylc/cylc-rose#92 - there doesn't seem to be any changes to the entry points there. Had the change to the entry point(s) already happened in an earlier PR?
The functionality this PR uses has existed in Cylc Rose for a long time, but hadn't been used by the code in |
This comment has been minimized.
This comment has been minimized.
4ed30d5
to
5ee405a
Compare
This is a small change with no associated Issue:
Cylc was forced to run cylc-rose twice under some circumstances to give uninstalled workflows access to CLI variables. This PR passes CLI variable to Parsec instead.
Partner of cylc/cylc-rose#92 - Both are required for testing.
It replaces #4462 .
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.setup.py
andconda-environment.yml
.