Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that each config item has at least a one line description #4915

Closed
MetRonnie opened this issue Jun 15, 2022 · 9 comments · Fixed by #4954 or #4999
Closed

Ensure that each config item has at least a one line description #4915

MetRonnie opened this issue Jun 15, 2022 · 9 comments · Fixed by #4954 or #4999
Assignees
Labels
doc Documentation
Milestone

Comments

@MetRonnie
Copy link
Member

MetRonnie commented Jun 15, 2022

In the workflow and global config reference docs

@MetRonnie MetRonnie added the doc Documentation label Jun 15, 2022
@MetRonnie MetRonnie modified the milestones: cylc-8.0rc5, cylc-8.0.0 Jun 15, 2022
@MetRonnie MetRonnie changed the title Check that each config item has a one line summary at the top. Check that each config item has at least a one line description Jun 15, 2022
@MetRonnie MetRonnie changed the title Check that each config item has at least a one line description Ensure that each config item has at least a one line description Jun 15, 2022
@wxtim
Copy link
Member

wxtim commented Jun 28, 2022

>>> from cylc.flow.cfgspec.workflow import SPEC
>>> from cylc.flow.cfgspec.globalcfg import SPEC as GSPEC
>>> print('\n - [ ] '.join([repr(i[1]).replace('<', '&lt;') for i in SPEC.walk() if not i[1].desc]))
>>> print('\n - [ ] '.join([repr(i[1]).replace('<', '&lt;') for i in GSPEC.walk() if not i[1].desc]))

@wxtim wxtim self-assigned this Jun 28, 2022
@datamel
Copy link
Contributor

datamel commented Jun 29, 2022

@wxtim Something like:

diff --git a/cylc/flow/cfgspec/globalcfg.py b/cylc/flow/cfgspec/globalcfg.py
--- a/cylc/flow/cfgspec/globalcfg.py
+++ b/cylc/flow/cfgspec/globalcfg.py
@@ -792,7 +792,10 @@ with Conf('global.cylc', desc='''
 
             .. versionadded:: 8.0.0
         """):
-            with Conf('<install target>'):
+            with Conf('<install target>',
+                      desc="""
+                Install target where directories to be symlinked are located.
+            """):
                 Conf('run', VDR.V_STRING, None, desc="""
                     Alternative location for the run dir.

@wxtim
Copy link
Member

wxtim commented Jul 21, 2022

Only flow.cylc[scheduler][events] left...

@MetRonnie
Copy link
Member Author

Most of the global.cylc[platforms][<platform name>]retrieve job logs * do not have a description (even if they are relatively self-explanatory)

@wxtim
Copy link
Member

wxtim commented Jul 21, 2022

Most of the global.cylc[platforms][<platform name>]retrieve job logs * do not have a description (even if they are relatively self-explanatory)

really? Not what I'm seeing!

@MetRonnie
Copy link
Member Author

MetRonnie commented Jul 21, 2022

They just have the versionchanged admonition (apart from retrieve job logs command)

@wxtim
Copy link
Member

wxtim commented Jul 21, 2022

They just have the versionchanged admonition (apart from retrieve job logs command)

Legit and well checked - will fix on my return from lunch, although possibly out of scope for this ticket because there is some info there, it's just not terribly enlightning.

@hjoliver
Copy link
Member

hjoliver commented Jul 21, 2022

Hold off @wxtim - I'm just about to post a PR myself.

(I also missed these items at first, because they do have a description, just not one that explains what they mean).

@oliver-sanders
Copy link
Member

Issue still under progress:

some flow.cylc config item descriptions ... coming shortly

-- #4997 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation
Projects
None yet
5 participants