Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Config Documentation for items over-ridden in workflow config #4851

Closed
2 tasks done
wxtim opened this issue May 4, 2022 · 3 comments · Fixed by #4916
Closed
2 tasks done

Check Config Documentation for items over-ridden in workflow config #4851

wxtim opened this issue May 4, 2022 · 3 comments · Fixed by #4916
Assignees
Labels
doc Documentation
Milestone

Comments

@wxtim
Copy link
Member

wxtim commented May 4, 2022

Checks

  • Ensure that in all cases where config items are present in global.cylc and over-ridden in flow.cylc that there are references in both configs to the other, but a full description in only one.
    • For example, abort handlers, which only has a link from global config to workflow, and not vice-versa.
  • Add an explanation to [runtime][__task__][remote] and [job] sections are only used to select a platform. Remove any suggestion that they over-ride other configs.

Decision making paper trail

From #4896 (comment):

... Dave and I have had a discussion about this, which we've not documented, but we have it in mind to go through all these cases: I think the agreement was that there should be:

  • A headline description [both]
  • A fuller description [only one config]
  • A link to the other conifg [both]

Pull requests welcome!

This is an Open Source project - please consider contributing a bug fix
yourself (please read CONTRIBUTING.md before starting any work though).

@wxtim wxtim added the bug Something is wrong :( label May 4, 2022
@wxtim wxtim added this to the cylc-8.0rc4 milestone May 4, 2022
@wxtim wxtim added the BLOCKED This can't happen until something else does label May 4, 2022
@wxtim wxtim mentioned this issue May 5, 2022
13 tasks
@oliver-sanders oliver-sanders added small doc Documentation and removed bug Something is wrong :( labels May 12, 2022
@MetRonnie MetRonnie removed the BLOCKED This can't happen until something else does label Jun 7, 2022
@MetRonnie
Copy link
Member

I'm assuming no longer blocked as #4848 has been merged

@MetRonnie MetRonnie self-assigned this Jun 10, 2022
@MetRonnie
Copy link
Member

Ensure that in all cases where config items are present in global.cylc and over-ridden in flow.cylc that there are references in both configs to the other, but a full description in only one.

In practice this means writing the full description as a variable in globalcfg.py and importing that into workflow.py (has to be this way round to avoid circular imports). The full description is split on \n\n to get the one-liner actually used as the description in globalcfg.py. Note that this loses admonitions like .. versionchanged and .. warning, but it was decided in today's team catchup that we'd accept this in the interests of concision.

@MetRonnie MetRonnie removed the small label Jun 15, 2022
@MetRonnie
Copy link
Member

Split off #4915 from this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants