review response

cylc · Apr 18, 2023 · 94a61da · 94a61da
1 parent 812da58
commit 94a61da
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/cylc/flow/task_remote_mgr.py b/cylc/flow/task_remote_mgr.py
@@ -316,19 +316,18 @@ def _get_remote_tidy_targets(
             A mapping of install targets to valid platforms only where
             platforms are available.
         """
-        if not platform_names and install_targets:
+        if install_targets and not platform_names:
             install_targets_map: Dict[str, List[Dict[str, Any]]] = {
                 t: [] for t in install_targets}
+            unreachable_targets = install_targets
         else:
             install_targets_map = get_install_target_to_platforms_map(
                 platform_names, quiet=True)
+            # If we couldn't find a platform for a target, we cannot tidy it -
+            # raise an Error:
+            unreachable_targets = install_targets.difference(
+                install_targets_map)
 
-        # If we couldn't find a platform for a target, we cannot tidy it -
-        # raise an Error:
-        unreachable_targets = [
-            t for t, v in install_targets_map.items()
-            if not v
-        ] + list(install_targets.difference(install_targets_map))
         if unreachable_targets:
             msg = 'No platforms available to remote tidy install targets:'
             for unreachable_target in unreachable_targets: