-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve TypeScript #66
Conversation
Hmm... I just realized that I somehow managed to forget to actually add the That isn't a huge deal, since,
Edit: it looks like adding |
b855284
to
7340c3c
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #66 +/- ##
===========================================
- Coverage 100.00% 98.11% -1.89%
===========================================
Files 2 3 +1
Lines 231 265 +34
Branches 0 74 +74
===========================================
+ Hits 231 260 +29
- Partials 0 5 +5
☔ View full report in Codecov by Sentry. |
tsconfig.json - set declaration to true package.json - replace "src" with "src/*.js" in files array package.json - add .d.ts files to files array .eslintrc - ignore generated .d.ts files .gitignore - ignore generated .d.ts files
- Make capitalization and periods consistent in function doc comments - Update `compute` params to `host: string` Thankfully the function and parameter names are self-documenting enough that the doc comments needn't be more than a sentence.
Actually... looking at the It seems like it would be a bit of work to properly expand all those arbitrary tokens like "the user's home directory" and "the local hostname", it'd need a bunch of Node |
7340c3c
to
4d323b8
Compare
This makes them match `.compute`.
nice catch about TOKENS, yep I think token interpolation can be left out of this pr. |
I noticed when I first decided to take a look at this library for #65 that NPM does not show it as having declared types, nor does it have any in DefinitelyTyped. I was quite surprised to find out that this was despite the fact that it is written in TypeScript.
While I've never published a package with types, the TypeScript documentation on publishing makes it look like all you have to do is include
types
as a key in your package.json and point it to a.d.ts
file. This PR updatestsconfig.json
to emit declaration files, as well as updating the other rc/ignore/config files to exclude/include them as required. With this, the package should get its very own little TS badge! 😄← (this fella)