Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wallet.cpp for merge POS inputs automatic up to ~60 coins (POS diff *10) #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cryptonit
Copy link

@cryptonit cryptonit commented Jul 28, 2021

this change will lead to when i find a POS block with a input size smaller then acual diff *10 it will add another input and merge it until max 100 inputs are reached or all inputs together are bigger then diff * 10

at actual POS diff this would lead to coinpile size of around 60 CURE

why this change is important?

first of all its non mandatory this means each wallet can have his own prefered setting

i for example tested it with * 100 and the result is like this:
https://chainz.cryptoid.info/cure/block.dws?593145.htm

but for everyone use *10 is better

at actual setting at a POS diff pof like 6 coin pile would split down until 2 coin size and not merge together

if u have many coins this make ur wallet very slow as it holds like many thousand unspend transactions

as im with DMD Diamond since 2013 im used to POS coincode our original staking engine was pretty similar to what u use now

take it as improvement or leave it as every user can change this on his own and compile wallet its no issue for experenced users

but it make life much more easy for the non techie owner of like 100k cure where i guess a few exist

additional info it only affect possible unspend transactions to merge which reach a certain age as u can see here

https://github.com/cryptonit/CurecoinSource/blob/master/src/wallet.cpp#L1585

and if coinpile that find block is yournger then 90 days then he still split and not meger

all this behavior together take care u still dont run into a nothing to stake issue

as if young coins easy find blocks because of low competition they always split and the competition raise

this change will lead to when i find a POS block with a input size smaller then acual diff *10 it will add another input and merge it until max 100 inputs are reached or all inputs together are bigger then diff * 10

at actual POS diff this would lead to coinpile size of around 60 CURE

why this change is important?

first of all its non mandatory this means each wallet can have his own prefered setting

i for example tested it with  * 100 and the result is like this:
https://chainz.cryptoid.info/cure/block.dws?593145.htm

but for everyone use *10 is better

at actual setting at a POS diff pof like 6 coin pile would split down until 2 coin size and not merge together

if u have many coins this make ur wallet very slow as it holds like many thousand unspend transactions

as im with DMD Diamond since 2013 im used to POS coincode our original staking engine was pretty similar to what u use now

take it as improvement or leave it as every user can change this on his own and compile wallet its no issue for experenced users

but it make life much more easy for the non techie owner of like 100k cure where i guess a few exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant