Small syntax enhancement to TMPLIT_EXPR

[svdb99]

This issue proposes a small enhancement to the regexp in the TMPLIT_EXPR const.

Background & Context

const TMPLIT_EXPR = seal(/\${[\w\W]*}/gm);

Projects that use XSLT can inline 3rd party libs before pushing out the response to the browser. While doing so they can perform code resolution/substitutions on ${} espressions. Unfortunately the ${[\w\W]*} part can be misinterpreted as an expression even though it's in a regexp, and because it obviously doesn't resolve to anything during the transformation, it gets wiped out as a result and causes a syntax error when the browser gets it.
Result: const TMPLIT_EXPR = seal(/\/gm);

Proposed workaround

The solution is extremely simple and doesn't change anything to how the regexp operates, and would improve compatibility with a wider range of mission critical projects build on "older" tech like XSLT.
All that is needed is to escape the first curly brace like so:
const TMPLIT_EXPR = seal(/\$\{[\w\W]*}/gm);

Would you like me to create a PR for this?

[cure53]

Heya, this looks good from my end, thanks - a PR is welcome 🙂

[svdb99]

Hi,
Unfortunately my access is read-only, it seems. I can't push my scratch branch.
"Permission to cure53/DOMPurify.git denied to svdb99."

[cure53]

You can just create a PR, then it works as expected :)

[svdb99]

Had to remember how to do it in this non-enterprise version of Github. It's a bit different than how we use it. 😅

[cure53]

We need some changes to the PR, see failed tests.

[svdb99]

The Lint error wants to optimize the regexp by removing the escape character I added.
This "optimization" is precisely what caused the issue in the first place.

[svdb99]

Hi, for some reason version 3.2.2 doesn't contain the fix.
When downloading the zip I can see the fix is in the .ts in the src folder, but it's not included in the files in the dist folder.

[cure53]

Oh, dang - somehow it indeed didn't make it into the dist files. Okay for you to wait for 3.2.3 for that?

[svdb99]

Yes, no pb, nothing's gonna happen until next week on our side.

[svanden99]

Hi,
Would you be able to tell me approximately when the next release is planned for?
Thanks!

[cure53]

Monday, the latest :)