Fix Calyx backend issue with emitting signed binops #430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes point number 2 in #427
Background
Dahlia was emitting Calyx primitives incorrectly for signed ops.
eg)
The Calyx IR contains a std_sand primitive
Changes Summary
signed
in Helpers.scala to use the op to decide if a given op is signed or notNumOp
and use the previous behaviour