Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite to Scala 3 syntax using -rewrite flag #423

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Rewrite to Scala 3 syntax using -rewrite flag #423

merged 1 commit into from
Mar 8, 2024

Conversation

Mark1626
Copy link
Collaborator

@Mark1626 Mark1626 commented Mar 8, 2024

Follow up to #421

Summary

  1. Rewrite to Scala 3 syntax automatically by using the -indent -rewrite Scala 3 compiler flag
  2. Only the function def emitFor(cmd: CFor): Doc in CppRunnable.scala needed manual intervension

rachitnigam
rachitnigam approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@rachitnigam rachitnigam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rachitnigam rachitnigam merged commit 9cbf657 into master Mar 8, 2024
1 check passed
@rachitnigam rachitnigam deleted the scala3-syntax-rewrite branch March 8, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachitnigam rachitnigam rachitnigam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mark1626 @rachitnigam