Add Support for Filtering Confluence V2 Bulk #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Confluence V2 API Bulk get supports filtering by IDs. This adds support for that parameter optionally and is completely backwards compatible.
Codecov Report
@@ Coverage Diff @@
## main #217 +/- ##
==========================================
+ Coverage 85.48% 85.53% +0.04%
==========================================
Files 137 137
Lines 11626 11678 +52
==========================================
+ Hits 9939 9989 +50
- Misses 941 942 +1
- Partials 746 747 +1
|
There are more parameters available to the bulk query which would, unfortunately, not be backward compatible with current version of Bulk so rather than affecting that, I'm switching to having one implementation that can handle all the filtering and Bulk() calls it without any filtering.
squatched
changed the title
ctreminiom
added
bug
|
Hi @squatched, PR approved!! Thanks for contributing on this project 👍🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Confluence V2 API Bulk get supports filtering by IDs and status. This adds
support for those and body-format in the form of an additional method
BulkFiltered().Fixes #218.