Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ Migrated the Jira SM module #145

Merged
merged 6 commits into from
Sep 20, 2022

Conversation

ctreminiom
Copy link
Owner

  1. Created the dedicated interfaces for the Jira Service Management module.

  2. Created more custom errors.

  3. Moved the dedicated structs to the model folder.

1. Created the dedicated interfaces for the Jira Service Management module.

2. Created more custom errors.

3. Moved the dedicated structs to the model folder.
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #145 (d6b8e3c) into main (6040361) will decrease coverage by 3.04%.
The diff coverage is 73.41%.

@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   86.71%   83.66%   -3.05%     
==========================================
  Files         115      115              
  Lines        9340     9614     +274     
==========================================
- Hits         8099     8044      -55     
- Misses        681      961     +280     
- Partials      560      609      +49     
Impacted Files Coverage Δ
jira/agile/internal/authentication_impl.go 50.00% <0.00%> (-8.83%) ⬇️
jira/internal/authentication_impl.go 50.00% <0.00%> (-8.83%) ⬇️
jira/sm/internal/organization_impl.go 0.00% <0.00%> (ø)
jira/sm/internal/authentication_impl.go 47.61% <47.61%> (ø)
jira/sm/api_client_impl.go 49.25% <49.25%> (ø)
jira/sm/internal/attachment_impl.go 87.50% <87.50%> (ø)
jira/sm/internal/info_impl.go 88.88% <88.88%> (ø)
jira/sm/internal/customer_impl.go 90.24% <90.24%> (ø)
jira/sm/internal/approval_impl.go 90.47% <90.47%> (ø)
jira/sm/internal/service_desk_impl.go 90.47% <90.47%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

1. The "X-ExperimentalApi", "opt-in" needs to be set when the Jira API endpoint is not stable.

2. This change adds the Experimental flag on authentication.go
@ctreminiom ctreminiom merged commit a1fb0da into main Sep 20, 2022
@ctreminiom ctreminiom deleted the feature/refactor-service-manage-module branch May 15, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant