Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Edited IssueTypeScreenSchemeMappingPayloadScheme #132

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

ctreminiom
Copy link
Owner

  1. Added the Description tag on the struct IssueTypeScreenSchemeMappingPayloadScheme
  2. Closes IssueTypeScreenSchemeService: add description field when creating issue type screen schemes #131

1. Added the Description tag on the struct IssueTypeScreenSchemeMappingPayloadScheme
2. Closes #131
@ctreminiom ctreminiom added the enhancement New feature or request label Aug 5, 2022
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #132 (9dc118e) into main (0e44336) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files         158      158           
  Lines       11661    11661           
=======================================
  Hits        11655    11655           
  Misses          3        3           
  Partials        3        3           

Help us with your feedback. Take ten seconds to tell us how you rate us.

@iacabezasbaculima
Copy link

@ctreminiom It seems that you added the description field in a different struct.

I was referring to the following struct:

type IssueTypeScreenSchemePayloadScheme struct {
	Name              string                                       `json:"name,omitempty"`
---> add 'description' field here <---
	IssueTypeMappings []*IssueTypeScreenSchemeMappingPayloadScheme `json:"issueTypeMappings,omitempty"`
}

The struct above is used to create an issue type screen scheme by calling this API endpoint which supports passing a description.

Also, I think you may need to roll back this PR because the IssueTypeScreenSchemeMappingPayloadScheme used to specify issueTypeMappings does not support a description field passed in the Jira API endpoint payload schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

IssueTypeScreenSchemeService: add description field when creating issue type screen schemes
2 participants