Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated entryHeaderToBinary. #217

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Conversation

objectivecosta
Copy link
Contributor

Fixed a typo that made the CRC be written as an Int32 instead of a UInt32.

This caused some ZIP file creations to return an error, and not work correctly. Please advise if fix is incorrect.

Thanks! :)

@jmcollin78
Copy link
Contributor

Here you will find a fork that is fixing the issue: https://github.com/jmcollin78/adm-zip

it is published with the following name:

npm install adm-zip-jmcnet

@cthackers cthackers merged commit a097034 into cthackers:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants