Fix sharejail stat #4835
Merged
Fix sharejail stat #4835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
butonic
force-pushed
the
fix-sharejail-stat-id
branch
from
9e04421 to
2964a28
Compare
|
@micbar since you are knee deep in wopi work can you try this out with a working wopi setup? |
|
@butonic Is there any way (test instance or similar) that we could use to verify if it fixes the issue for the iOS app and/or if there are any other side effects? |
dragonchaser
approved these changes
Sep 25, 2024
|
You could use the ocis_full docker compose locally on this branch. Checkout this branch, then
|
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
fix-sharejail-stat-id
branch
from
2964a28 to
02af5a2
Compare
|
while the implementation is correct, the ocis testsuite needs a fix: owncloud/ocis#10172 (comment) |
|
test got added to expected failures, merging |
This was referenced Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stating a share jail mountpoint now returns the same resourceid as in the directory listing of the share jail root.
This needs to be tested with WOPI, as I fear the web client might now try to use the sharejail id to access a resource ...
see owncloud/ocis#9933