Enforce Favorite&Share Permissions #4325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobergj
force-pushed
the
EnforcePermissions
branch
4 times, most recently
from
d640629 to
4720f0a
Compare
Signed-off-by: jkoberg <[email protected]>
kobergj
force-pushed
the
EnforcePermissions
branch
from
4720f0a to
42f5853
Compare
2403905
reviewed
Nov 13, 2023
| @@ -217,6 +218,17 @@ func (s *svc) handleProppatch(ctx context.Context, w http.ResponseWriter, r *htt | |||
| return nil, nil, false | |||
| } | |||
| currentUser := ctxpkg.ContextMustGetUser(ctx) | |||
| ok, err := utils.CheckPermission(ctx, "Favorites.Write", client) | |||
There was a problem hiding this comment.
Can we use the constant WriteFavorites from a pkg/permission/permission.go instead of the "Favorites.Write"?
There was a problem hiding this comment.
utils.CheckPermission(ctx, permission.WriteFavorites, client)
There was a problem hiding this comment.
Excellent idea 👍 I did it for other occurrences of CheckPermission too. Please double check.
Signed-off-by: jkoberg <[email protected]>
2403905
approved these changes
Nov 13, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See owncloud/ocis#7497 for details