Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS3 pulltransfer #1824

Closed
wants to merge 3 commits into from
Closed

CS3 pulltransfer #1824

wants to merge 3 commits into from

Conversation

redblom
Copy link
Contributor

@redblom redblom commented Jun 24, 2021

New CS3 datatx methods to support pull model.
See cs3org/cs3apis#134

@redblom redblom requested a review from labkode as a code owner June 24, 2021 12:26
@ishank011
Copy link
Contributor

@redblom do we have the complete workflow now? Did you run any end-to-end tests?

@redblom
Copy link
Contributor Author

redblom commented Jun 30, 2021

@ishank011 : end-to-end create/accept share tests are successful (both regular and tx shares)

@ishank011
Copy link
Contributor

I don't see the implementation? Can you create a single PR for the changes? And add the command usage and workflow to the description? (Something like #1743 (comment))

@redblom
Copy link
Contributor Author

redblom commented Jul 6, 2021

@ishank011 : I'm struggling to get the dest webdav endpoint at service.datatx level that's needed for the rclone driver call. There's no access there to the gateway funcs.
Should I inject gateway access or ... inject the dest webdav endpoint?

Or maybe the CS3 PullTransferRequest is simply lacking the destination targetURI ... so maybe it should have targetURIs for both src and dest ?

@redblom
Copy link
Contributor Author

redblom commented Jul 7, 2021

@ishank011 : the home dir is part of the src file path, eg. /home/mybigfiles/files-to-transfer ...
Upon transfer the files will then be uploaded at dest to /home/Data-Transfers/home/mybigfiles/files-to-transfer ...

To me this seems a bit odd. I'm actually wondering if a home dir should be part of a share path at all ?

@ishank011
Copy link
Contributor

Yep you just take the base path from the target and prepend the configurable data-transfers directory to get the full destination path.

@redblom redblom closed this Sep 8, 2021
@redblom
Copy link
Contributor Author

redblom commented Sep 8, 2021

Superseded by #2052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants