Skip to content

Commit

Permalink
Merge pull request #4466 from kobergj/FixNatsAuthentication
Browse files Browse the repository at this point in the history
fix `nats-js-kv` store
  • Loading branch information
kobergj authored Jan 19, 2024
2 parents 92b354d + 2efec8f commit b053838
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
5 changes: 5 additions & 0 deletions changelog/unreleased/fix-nats-store.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: Fix natsjskv store

Small mistake in last iteration made authorization not working.

https://github.com/cs3org/reva/pull/4466
6 changes: 1 addition & 5 deletions pkg/storage/utils/decomposedfs/options/options.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,7 @@ type AsyncPropagatorOptions struct {

// EventOptions are the configurable options for events
type EventOptions struct {
NatsAddress string `mapstructure:"natsaddress"`
NatsClusterID string `mapstructure:"natsclusterid"`
TLSInsecure bool `mapstructure:"tlsinsecure"`
TLSRootCACertificate string `mapstructure:"tlsrootcacertificate"`
NumConsumers int `mapstructure:"numconsumers"`
NumConsumers int `mapstructure:"numconsumers"`
}

// TokenOptions are the configurable option for tokens
Expand Down
4 changes: 2 additions & 2 deletions pkg/store/store.go
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,8 @@ func Create(opts ...microstore.Option) microstore.Store {
}
return natsjskv.NewStore(
append(opts,
natsjs.NatsOptions(natsOptions), // always pass in properly initialized default nats options
natsjs.DefaultTTL(ttl))...,
natsjskv.NatsOptions(natsOptions), // always pass in properly initialized default nats options
natsjskv.DefaultTTL(ttl))...,
)
case TypeMemory, "mem", "": // allow existing short form and use as default
return microstore.NewMemoryStore(opts...)
Expand Down

0 comments on commit b053838

Please sign in to comment.