Merge pull request #4964 from aduffeck/debug-wopi-500

Handle permission denied errors when touching the new file
cs3org · Nov 20, 2024 · 931da98 · 931da98
2 parents 4f31fd9 + 336e871
commit 931da98
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/changelog/unreleased/fix-approvider-error.md b/changelog/unreleased/fix-approvider-error.md
@@ -0,0 +1,5 @@
+Bugfix: Fix a wrong error code when approvider creates a new file
+
+We fixed a problem where the approvider would return a 500 error instead of 403 when trying to create a new file in a read-only share.
+
+https://github.com/cs3org/reva/pull/4964
diff --git a/internal/http/services/appprovider/appprovider.go b/internal/http/services/appprovider/appprovider.go
@@ -237,6 +237,10 @@ func (s *svc) handleNew(w http.ResponseWriter, r *http.Request) {
 	}
 
 	if touchRes.Status.Code != rpc.Code_CODE_OK {
+		if touchRes.Status.Code == rpc.Code_CODE_PERMISSION_DENIED {
+			writeError(w, r, appErrorPermissionDenied, "permission denied to create the file", nil)
+			return
+		}
 		writeError(w, r, appErrorServerError, "touching the file failed", nil)
 		return
 	}