Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data transfer pull model #143

Merged
merged 4 commits into from
Feb 14, 2022
Merged

Data transfer pull model #143

merged 4 commits into from
Feb 14, 2022

Conversation

redblom
Copy link
Contributor

@redblom redblom commented Sep 8, 2021

Functionality for data transfer based on pull model.

tx-pull-model-01

@redblom redblom requested a review from labkode as a code owner September 8, 2021 07:47
@redblom redblom changed the title [WIP] Data transfer pull model Data transfer pull model Sep 27, 2021
@redblom
Copy link
Contributor Author

redblom commented Sep 27, 2021

@labkode @ishank011 please review

Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with Antoon, this was tested locally and can be merged as soon as cs3org/reva#2052 is ready for merge.

(To be noted that this is a breaking change of the CS3APIs, therefore we have to coordinate the merge of both PRs)

@labkode
Copy link
Member

labkode commented Dec 13, 2021

@redblom can you bring cs3org/reva#2052 up to date and then we merge it!

@glpatcern glpatcern self-requested a review February 11, 2022 10:08
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now following the rebase!

@glpatcern glpatcern merged commit dfd5454 into cs3org:main Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants