fix: use the shrunken abi values as the msg's data #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this also explains the strange behavior I was seeing with shrinking where the call sequence appeared to have shrunk but remained unchanged |
|
It also seems to have improved on this example #229 (comment) |
anishnaik
approved these changes
Jun 24, 2024
|
awesome find, thanks @0xalpharush |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During input shrinking, the msg's data was not being re-encoded so there were duplicate entires in the
test_resultsdirectory that seemed unique based on theirinputValuesfield but had the samedatafield.Closes #338