Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add execution trace for failed target contract deployments #337

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

0xalpharush
Copy link
Contributor

@0xalpharush 0xalpharush commented Mar 20, 2024

Closes #304. This is progress towards #320 but does not handle the source mapping.

contract Y {
    constructor() public {
        revert();
    }
}

contract X {
    constructor() public {
        new Y();
    }
}
Screenshot 2024-03-20 at 4 07 23 PM

fuzzing/fuzzer.go Outdated Show resolved Hide resolved
@anishnaik
Copy link
Collaborator

anishnaik commented Mar 27, 2024

A few other things were changed in this PR:

  1. The chain setup function now returns an execution trace. This can be logged to all channels so that users are aware where a deployment failure occurred.
  2. Fixed a bug in the log buffer.
  3. Errors are no longer indented. This makes it look better when printing an execution trace

@anishnaik anishnaik merged commit e7b5e15 into master Mar 27, 2024
9 checks passed
@anishnaik anishnaik deleted the feat/target-deployment-exec-trace branch March 27, 2024 16:27
Leeyah-123 pushed a commit to Leeyah-123/medusa that referenced this pull request Jun 4, 2024
…tic#337)

* feat: add execution trace for failed target contract deployments

* fix bugs in logging and improve trace output to console

---------

Co-authored-by: anishnaik <[email protected]>
s4nsec pushed a commit that referenced this pull request Jul 9, 2024
* feat: add execution trace for failed target contract deployments

* fix bugs in logging and improve trace output to console

---------

Co-authored-by: anishnaik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Error reporting when constructor reverts
2 participants