Fix stringification of abnormal Process::Status
on Windows [fixup #15255]
#15267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in #15255 broke
Process::Status#to_s
and#inspect
on Windows due to the redefinition of#normal_exit?
. Unfortunately we were missing specs for this, so it did go unnoticed.This patch adds specs and restablishes the previous behaviour with the small improvement of treating the
exit_status
value asUInt32
instead ofInt32
, which results in positive numbers.There's still room for improvement, for example map the values to names and/or use base 16 numerals as is custom for error statuses on Windows), but I'll leave that for a follow-up.