Drop Crystal::FiberChannel #15245
Open
Drop Crystal::FiberChannel #15245
+11
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its main purpose was to keep the eventloop from exiting when empty, which isn't needed anymore (evloop#run can now wait forever). Since we need to grab the lock to send the fiber, we can just push it to the runnables deque instead of passing it through a pipe; which didn't work properly on Windows anyway. The Windows IOCP eventloop will need a refactor to check on completions even where there are no queued (timers).
straight-shoota
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its main purpose was to keep the libevent eventloop from exiting when empty, which isn't needed anymore since EventLoop#run(blocking: true) now waits forever when blocking.
Since we need to grab the lock to send the fiber, we can just push it to the runnables Deque instead of passing it through a pipe, which didn't work properly on Windows anyway.
Should be merged after #15238 and #15243.MergedNote: there ain't much differences with #14949 (kept
@sleepingbool + spec fix). We might want to consider merging the original PR instead.