Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise on abnormal exit in Procss::Status#exit_code #15241

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Raise on abnormal exit in Procss::Status#exit_code #15241

merged 1 commit into from
Dec 3, 2024

Conversation

straight-shoota
Copy link
Member

Resolves #15228

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. breaking-change topic:stdlib:system labels Dec 2, 2024
@straight-shoota straight-shoota self-assigned this Dec 2, 2024
@straight-shoota straight-shoota added this to the 1.15.0 milestone Dec 2, 2024
@straight-shoota straight-shoota merged commit 099f572 into crystal-lang:master Dec 3, 2024
69 checks passed
@straight-shoota straight-shoota deleted the chore/process_status.exit_code-raise branch December 3, 2024 21:22
@straight-shoota straight-shoota mentioned this pull request Dec 3, 2024
Merged
straight-shoota added a commit that referenced this pull request Dec 7, 2024
@straight-shoota
Add Process::Status#exit_code? (#15247)
655b8a5 
This provides an alternative to #exit_code which raises in this case since #15241.
@straight-shoota straight-shoota mentioned this pull request Dec 7, 2024
Merged
straight-shoota added a commit that referenced this pull request Dec 10, 2024
@straight-shoota
Refactor use of Process::Status#exit_code to #exit_code? (#15254)
6abe0ba 
Use the new non-raising variant `#exit_code?` (introduced in #15247) where possible over `#exit_code` which raises since #15241. The code can also be simplified in some cases, removing unnecessary calls to `Status#normal_exit?`.
This was referenced Dec 11, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysbaddaden ysbaddaden ysbaddaden approved these changes

Assignees

@straight-shoota straight-shoota

Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:system
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

Process::Status#exit_code returns 0 on signal exit
2 participants
@straight-shoota @ysbaddaden