Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: no python and nix format checker in CI #80

Merged
merged 5 commits into from
Sep 18, 2021

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Sep 17, 2021

Closes: #79

  • Run flake8 for python
  • Run nixpkgs-fmt for nix

๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! ๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Closes: crypto-org-chain#79

- Run flake8 for python
- Run nixpkgs-fmt for nix
@yihuang yihuang requested a review from a team as a code owner September 17, 2021 02:42
@yihuang yihuang requested review from JayT106 and leejw51crypto and removed request for a team September 17, 2021 02:42
@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #80 (efe84c9) into main (3ea70c5) will increase coverage by 4.64%.
The diff coverage is 41.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   21.51%   26.15%   +4.64%     
==========================================
  Files          27       32       +5     
  Lines        1729     2183     +454     
==========================================
+ Hits          372      571     +199     
- Misses       1324     1575     +251     
- Partials       33       37       +4     
Impacted Files Coverage ฮ”
app/app.go 3.89% <0.00%> (-0.07%) โฌ‡๏ธ
x/cronos/keeper/grpc_query.go 0.00% <0.00%> (รธ)
x/cronos/keeper/hooks.go 0.00% <0.00%> (รธ)
x/cronos/keeper/msg_server.go 6.45% <0.00%> (รธ)
x/cronos/types/query.pb.gw.go 0.00% <0.00%> (รธ)
x/cronos/types/tracer.go 0.00% <0.00%> (รธ)
x/cronos/keeper/evm.go 57.62% <66.66%> (+5.90%) โฌ†๏ธ
x/cronos/keeper/evmhooks.go 80.00% <80.00%> (รธ)
x/cronos/keeper/evm_log_handlers.go 86.51% <86.51%> (รธ)
x/cronos/keeper/ibc.go 83.06% <100.00%> (+4.88%) โฌ†๏ธ
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
ฮ” = absolute <relative> (impact), รธ = not affected, ? = missing data
Powered by Codecov. Last update 2f8a1a4...efe84c9. Read the comment docs.

@yihuang yihuang merged commit a3b9829 into crypto-org-chain:main Sep 18, 2021
@yihuang yihuang deleted the pylint branch September 18, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: no python and nix format checker in CI
2 participants