Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: interchain-accounts integration is not mature #672

Merged
merged 8 commits into from
Aug 25, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Aug 25, 2022

Closes: #671
Solution:

  • revert from 0.9

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner August 25, 2022 01:27
@yihuang yihuang requested review from thomas-nguy, adu-crypto and tomtau and removed request for a team August 25, 2022 01:27
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #672 (8b89e61) into main (6d14b41) will increase coverage by 0.36%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
+ Coverage   32.75%   33.12%   +0.36%     
==========================================
  Files          34       34              
  Lines        1612     1594      -18     
==========================================
  Hits          528      528              
+ Misses       1031     1013      -18     
  Partials       53       53              
Impacted Files Coverage Δ
app/upgrades.go 0.00% <0.00%> (ø)

@yihuang yihuang requested a review from thomas-nguy August 25, 2022 06:03
@yihuang yihuang merged commit 41d451f into crypto-org-chain:main Aug 25, 2022
@yihuang yihuang deleted the revert-ica branch August 25, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: interchain-accounts is not stable yet
2 participants