Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: gravity bridge integration test fails occasionally #538

Merged
merged 4 commits into from
Jun 6, 2022
Merged

Problem: gravity bridge integration test fails occasionally #538

merged 4 commits into from
Jun 6, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Jun 6, 2022 •
edited
Loading

Closes: #48

  • fix port conflicts between ibc and gravity bridge tests.
  • Add traceback env var for easier debug in the future.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang force-pushed the debug-gravity-test-failure branch from 6b2ad17 to 04e6b8a Compare June 6, 2022 06:06
yihuang
yihuang commented Jun 6, 2022
View reviewed changes
scripts/run-integration-tests Outdated Show resolved Hide resolved
@yihuang yihuang marked this pull request as ready for review June 6, 2022 08:01
@yihuang yihuang requested a review from a team as a code owner June 6, 2022 08:01
@yihuang yihuang requested review from JayT106 and thomas-nguy and removed request for a team June 6, 2022 08:01
thomas-nguy
thomas-nguy reviewed Jun 6, 2022
View reviewed changes
Copy link
Collaborator

@thomas-nguy thomas-nguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yihuang yihuang merged commit c90f4f5 into crypto-org-chain:main Jun 6, 2022
@yihuang yihuang deleted the debug-gravity-test-failure branch June 6, 2022 08:55
yihuang added a commit to yihuang/cronos that referenced this pull request Jun 10, 2022
@yihuang
Problem: gravity bridge integration test fails occasionally (crypto-o…
838023b 
…rg-chain#538)

* Problem: gravity bridge integration test fails occasionally

WIP: crypto-org-chain#48

- Add traceback env var to debug

* run ibc test together

* avoid port conflict

* Update scripts/run-integration-tests
yihuang added a commit to yihuang/cronos that referenced this pull request Jun 13, 2022
@yihuang
Problem: failed tx are ignored in json-rpc apis (backport crypto-org-…
b90b527 
…chain#502)

Solution:
- fix the issue in ethermint by emitting extra events in ante handler.
- add integration test to test it.
- update cosmos-sdk dependency
- fix getTransactionReceiptsByBlock

fix integration test

move to crypto-org-chain repo

Update CHANGELOG.md

update cosmos-sdk to most recent

cosmos-sdk v0.45.5

Problem: gravity bridge integration test fails occasionally (crypto-org-chain#538)

* Problem: gravity bridge integration test fails occasionally

WIP: crypto-org-chain#48

- Add traceback env var to debug

* run ibc test together

* avoid port conflict

* Update scripts/run-integration-tests
yihuang added a commit that referenced this pull request Jun 14, 2022
@yihuang
Problem: failed tx are ignored in json-rpc apis (backport #502) (#503)
75c2672 
* Problem: failed tx are ignored in json-rpc apis (backport #502)

Solution:
- fix the issue in ethermint by emitting extra events in ante handler.
- add integration test to test it.
- update cosmos-sdk dependency
- fix getTransactionReceiptsByBlock

fix integration test

move to crypto-org-chain repo

Update CHANGELOG.md

update cosmos-sdk to most recent

cosmos-sdk v0.45.5

Problem: gravity bridge integration test fails occasionally (#538)

* Problem: gravity bridge integration test fails occasionally

WIP: #48

- Add traceback env var to debug

* run ibc test together

* avoid port conflict

* Update scripts/run-integration-tests

* delay start of gorc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-nguy thomas-nguy thomas-nguy approved these changes

@JayT106 JayT106 Awaiting requested review from JayT106 JayT106 is a code owner automatically assigned from crypto-org-chain/cronos-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem: gravity bridge integration test fails occasionally
2 participants
@yihuang @thomas-nguy