Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: no rollback command to help with app-hash mismatch situation #481

Closed
wants to merge 3 commits into from
Closed

Problem: no rollback command to help with app-hash mismatch situation #481

wants to merge 3 commits into from

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented May 18, 2022 •
edited
Loading

ref: #284

Solution:

  • add rollback command implemented in cosmos-sdk
  • add integration tests for it

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

yihuang
yihuang commented May 18, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
yihuang added a commit to yihuang/cronos that referenced this pull request May 20, 2022
@yihuang
Problem: no rollback command to help with app-hash mismatch situation…
c71b363 
… (backport crypto-org-chain#481)

Solution:
- add rollback command implemented in cosmos-sdk

add --delete-pending-block option

fix build

update cosmos-sdk

test rollback
yihuang added a commit to yihuang/cronos that referenced this pull request May 20, 2022
@yihuang
Problem: no rollback command to help with app-hash mismatch situation…
0a4dd0e 
… (backport crypto-org-chain#481)

Solution:
- add rollback command implemented in cosmos-sdk

add --delete-pending-block option

fix build

update cosmos-sdk

test rollback
yihuang added a commit to yihuang/cronos that referenced this pull request May 20, 2022
@yihuang
Problem: no rollback command to help with app-hash mismatch situation
79891ae 
Solution:
- add rollback command implemented in cosmos-sdk
- add integration tests for rollback command

Problem: no rollback command to help with app-hash mismatch situation (backport crypto-org-chain#481)

Solution:
- add rollback command implemented in cosmos-sdk
- add integration tests for rollback
@yihuang yihuang marked this pull request as ready for review May 20, 2022 06:05
@yihuang yihuang requested a review from a team as a code owner May 20, 2022 06:05
@yihuang yihuang requested review from JayT106 and leejw51crypto and removed request for a team May 20, 2022 06:05
yihuang
yihuang commented May 20, 2022
View reviewed changes
go.mod
@@ -153,7 +153,7 @@ require (
replace (
// TODO: fix keyring upstream
github.com/99designs/keyring => github.com/crypto-org-chain/keyring v1.1.6-fixes
github.com/cosmos/cosmos-sdk => github.com/cosmos/cosmos-sdk v0.45.4
github.com/cosmos/cosmos-sdk => github.com/crypto-org-chain/cosmos-sdk v0.44.4-0.20220518122256-e49cc20318cf
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cosmos/cosmos-sdk#11982

@yihuang yihuang marked this pull request as draft May 20, 2022 06:09
@yihuang
Problem: no rollback command to help with app-hash mismatch situation
4dca518 
Solution:
- add rollback command implemented in cosmos-sdk
- add integration tests for rollback command

Problem: no rollback command to help with app-hash mismatch situation (backport crypto-org-chain#481)

Solution:
- add rollback command implemented in cosmos-sdk
- add integration tests for rollback
yihuang
yihuang commented May 20, 2022
View reviewed changes
go.mod
@@ -163,5 +163,7 @@ replace (
// TODO: remove when gravity update dependencies
github.com/peggyjv/gravity-bridge/module/v2 => github.com/crypto-org-chain/gravity-bridge/module/v2 v2.0.0-20220509015341-a016e2b04866

github.com/tendermint/tendermint => github.com/yihuang/tendermint v0.34.14-0.20220518061324-81344ac9464d
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tendermint/tendermint#8574

yihuang added a commit to yihuang/cronos that referenced this pull request May 23, 2022
@yihuang
Problem: no rollback command to help with app-hash mismatch situation…
03f6f87 
… (backport crypto-org-chain#481)

Solution:
- add rollback command implemented in cosmos-sdk
- add integration tests for rollback
@yihuang
Copy link
Collaborator Author

yihuang commented Aug 30, 2022

will move this integration test to ethermint.

@yihuang yihuang closed this Aug 30, 2022
@yihuang yihuang deleted the rollback-cmd branch August 30, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JayT106 JayT106 Awaiting requested review from JayT106 JayT106 is a code owner automatically assigned from crypto-org-chain/cronos-dev

@leejw51crypto leejw51crypto Awaiting requested review from leejw51crypto leejw51crypto is a code owner automatically assigned from crypto-org-chain/cronos-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yihuang