Problem: iavl pruning bug fix not included

[yihuang]

Closes: #1672

cosmos/iavl@v1.2.0...594b181

Solution:

• update dependency to release/v1.2.x

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

• Have you read the CONTRIBUTING.md?
• Does your PR follow the C4 patch requirements?
• Have you rebased your work on top of the latest master?
• Have you checked your code compiles? (make)
• Have you included tests for any non-trivial functionality?
• Have you checked your code passes the unit tests? (make test)
• Have you checked your code formatting is correct? (go fmt)
• Have you checked your basic code style is fine? (golangci-lint run)
• If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• If your changes affect the client infrastructure, have you run the integration test?
• If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

• New Features

  • Added a section for bug fixes in the changelog, including a pruning fix for the iavl dependency.
  • Support for registering payees in the relayer precompile.

• Improvements

  • Updated various dependencies to enhance performance and compatibility.
  • Updated Go version to 1.22.7 and toolchain to go1.23.1.

• Documentation

  • Changelog updated to reflect new features, improvements, and bug fixes.

[coderabbitai]

Walkthrough

The changes in this pull request involve updates to several files, primarily focusing on dependency management and documentation. The CHANGELOG.md has been revised to include a new section for bug fixes, specifically highlighting an update to the iavl dependency for a pruning fix. The go.mod file has seen multiple dependency updates, including the Go version and various libraries, while gomod2nix.toml reflects corresponding changes in module versions and hashes.

Changes

File	Change Summary
CHANGELOG.md	Added a new section for bug fixes under "UNRELEASED"; listed a specific change for iavl pruning fix. Retained existing sections for features and improvements.
go.mod	Updated Go version to 1.22.7; introduced new indirect dependency for github.com/cosmos/iavl, updated to v1.2.1-0.20240731145221-594b181f427e. Updated several dependencies to newer versions.
gomod2nix.toml	Updated module dependencies, including version and hash changes for github.com/cosmos/iavl and various replacements for other modules.

Assessment against linked issues

Objective	Addressed	Explanation
Fix panic when restarting node (#1672)	✅

Possibly related PRs

• Problem: cometbft not up to date #1568: Updates CHANGELOG.md to include a note about the cometbft library update.
• Problem: v1.4.0-rc0 is not released #1578: Updates go.mod to upgrade various dependencies, including cosmos-sdk.
• Problem: sdk v50 is not outdated #1614: Addresses the issue of the SDK version being outdated, relevant to the main PR's updates.
• Problem: app hash mismatch occurs when upgrade to iavl v1.2.0 #1618: Discusses compatibility with iavl version 1.2.0, directly related to the main PR's changes.
• Problem: fix of state overwrite in debug trace is not included #1655: Addresses state overwrite issues in debug trace APIs, relevant to the main PR's focus on dependency updates.

Suggested reviewers

• mmsqe
• thomas-nguy
• devashishdxt

🐰 In the meadow, where bunnies play,
New dependencies hop in, brightening the day.
With iavl fixed, the nodes restart,
A changelog updated, a work of art!
So let's celebrate, with a joyful cheer,
For code that runs smooth, and brings us near! 🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 45aaff0 and 418cdae.

⛔ Files ignored due to path filters (1)

• go.sum is excluded by !**/*.sum

📒 Files selected for processing (3)

• CHANGELOG.md (1 hunks)
• go.mod (1 hunks)
• gomod2nix.toml (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• CHANGELOG.md

🔇 Additional comments (3)

go.mod (2)

94-95: Testing Recommendation: Validate the fix with different pruning configurations.

Since this addresses a critical node restart issue, thorough testing is essential.

Please ensure to:

1. Test node restarts with pruning set to "default"
2. Test node restarts with pruning set to "everything"
3. Verify no panic occurs: "Value missing for key [...] corresponding to nodeKey ..."

---

94-95: LGTM! Verify that this IAVL version includes the pruning fix.

The update to IAVL v1.2.1-0.20240731145221-594b181f427e from the release/v1.2.x branch should address the node restart panic issue when pruning is enabled.

Let's verify the fix is included in this version:

gomod2nix.toml (1)

190-191: Verify the IAVL dependency update resolves the pruning bug.

The update to IAVL v1.2.1-0.20240731145221-594b181f427e appears to address the critical pruning bug mentioned in issue #1672. However, note that this is using a pre-release version with a specific commit hash.

Let's verify the version and its relationship to the bug fix:

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.27%. Comparing base (45aaff0) to head (418cdae).
Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1673       +/-   ##
===========================================
+ Coverage   16.84%   35.27%   +18.42%     
===========================================
  Files          72      123       +51     
  Lines        6161    11752     +5591     
===========================================
+ Hits         1038     4145     +3107     
- Misses       5000     7193     +2193     
- Partials      123      414      +291     

see 70 files with indirect coverage changes