Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: v1.4.0-rc2 is not released #1661

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Oct 23, 2024

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • New Features

    • Enhanced benchmark capabilities with support for batch mode and Cosmos broadcast RPC.
    • Implemented a load generator retry mechanism with backoff on errors.
    • Added an abort option in the PrepareProposal function.
  • Bug Fixes

    • Resolved issues with running a single validator benchmark locally.
    • Fixed unexpected conflicts in benchmark transactions and state overwrites in debug trace APIs.
    • Ensured the node can shut down by signal.
  • Improvements

    • Enabled parallel generation of test transactions on a single node.
    • Optimized scenarios where the block-list is empty and allowed skipping check-tx in benchmarks.

@yihuang yihuang marked this pull request as ready for review October 23, 2024 15:55
@yihuang yihuang requested a review from a team as a code owner October 23, 2024 15:55
@yihuang yihuang requested review from mmsqe and calvinaco and removed request for a team October 23, 2024 15:55
Copy link
Contributor

coderabbitai bot commented Oct 23, 2024

Walkthrough

The changelog has been updated to document the release of version v1.4.0-rc2, which includes various bug fixes and improvements. Key fixes address issues with validator benchmarks, node shutdown signals, benchmark transaction conflicts, and debug trace APIs. Improvements feature parallel test transaction generation, a load generator retry mechanism, an abort option in the PrepareProposal function, and enhanced benchmark capabilities. The changelog also reflects changes from the previous version v1.4.0-rc1, detailing significant updates and bug fixes.

Changes

File Change Summary
CHANGELOG.md Updated to reflect the release of version v1.4.0-rc2, detailing bug fixes and improvements, including changes from v1.4.0-rc1.

Possibly related PRs

Suggested reviewers

  • thomas-nguy
  • mmsqe
  • calvinaco

🐇 In the meadow, changes bloom,
A changelog brightens every room.
With fixes here and improvements there,
Version v1.4.0-rc2 shows we care!
Bugs are squashed, and features grow,
Hopping forward, let’s go, go, go! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
CHANGELOG.md (1)

3-4: Convert emphasized date to proper heading format.

The date is currently marked with emphasis (*) which should be converted to a proper heading for consistency and better document structure.

Apply this diff to fix the formatting:

-*Oct 24, 2024*
+### Oct 24, 2024
🧰 Tools
🪛 Markdownlint

3-3: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 1ae61b4 and 12975cb.

📒 Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
🧰 Additional context used
🪛 Markdownlint
CHANGELOG.md

3-3: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

🔇 Additional comments (1)
CHANGELOG.md (1)

Line range hint 5-24: LGTM! Well-structured changelog entry.

The changelog entry for v1.4.0-rc2 is well organized with:

  • Clear categorization of changes (Bug Fixes and Improvements)
  • Proper linking to GitHub PRs
  • Descriptive summaries of changes
🧰 Tools
🪛 Markdownlint

3-3: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
CHANGELOG.md (1)

3-4: Ensure date format consistency across changelog entries.

The date format should be consistent with other entries in the changelog. Consider using a more standardized format like "October 24, 2024" to match the style used in older entries.

-*Oct 24, 2024*
+*October 24, 2024*
🧰 Tools
🪛 Markdownlint

3-3: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 12975cb and c7fc6ab.

📒 Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
🧰 Additional context used
🪛 Markdownlint
CHANGELOG.md

3-3: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

🔇 Additional comments (2)
CHANGELOG.md (2)

5-5: LGTM: Version number follows semantic versioning.

The version number v1.4.0-rc2 correctly follows semantic versioning format (MAJOR.MINOR.PATCH-prerelease).


Line range hint 7-24: LGTM: Well-structured changelog sections.

The changelog entry is well-organized with clear sections for "Bug Fixes" and "Improvements". Each item is properly linked to its corresponding PR and includes a descriptive explanation of the changes.

🧰 Tools
🪛 Markdownlint

3-3: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
CHANGELOG.md (1)

3-4: Consider using a proper heading for the date.

Instead of using emphasis (*) for the date, consider using a proper markdown heading for better document structure.

-*Oct 24, 2024*
+### Oct 24, 2024
🧰 Tools
🪛 Markdownlint

3-3: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between c7fc6ab and 3442575.

📒 Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
🧰 Additional context used
🪛 Markdownlint
CHANGELOG.md

3-3: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

🔇 Additional comments (1)
CHANGELOG.md (1)

Line range hint 5-24: LGTM! Well-structured changelog entries.

The changelog entries for v1.4.0-rc2 are well-organized and informative:

  • Changes are properly categorized into "Bug Fixes" and "Improvements"
  • Each entry has a clear description and reference to the corresponding PR
  • The format is consistent with previous entries
🧰 Tools
🪛 Markdownlint

3-3: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants