optional binlog parameters in mysql connection string #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of DB default setting Signed-off-by: Marius Leahu <[email protected]>
Duologic
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MySQL binlog parameter in dsn (connection string) is currently mandatory, but this causes errors like
Error 1227: Access denied; you need (at least one of) the SUPER, BINLOG ADMIN privilege(s) for this operation
with AWS RDS MariaDB and default admin user.
Description of your changes
Binlog parameter for Users, Grants and Databases becomes optional and does not have a default value at all.
In this way, the
sql_bin_logparameter in DSN becomes optional and it is added only when binlog is explicitly set to true/false in one of the managed resources.Fixes the side effect of #171 in AWS RDS MariaDB.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Unit tests updated and added one more to cover the new case of missing binlog.
Tested with AWS RDS Mariadb: provisioned users, databases and grants.